Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a helper script for "devcontainer upgrades" #955

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

samruddhikhandale
Copy link
Member

@samruddhikhandale samruddhikhandale commented Feb 8, 2024

I usually run devcontainer upgrade command when I make any changes to an image(s). This script helps to fasten the process.

image

@samruddhikhandale samruddhikhandale requested a review from a team as a code owner February 8, 2024 19:06
echo "-----------------------------------------------"
echo "Upgrading image $IMAGE_NAME"
echo "-----------------------------------------------"
devcontainer upgrade --workspace-folder "${workspaceFolder}/${IMAGE_NAME}/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prepare release script is already doing this

echo "-----------------------------------------------"
echo "Releasing image $image"
echo "-----------------------------------------------"
bump_version $image
rm "${image}/.devcontainer/devcontainer-lock.json"
devcontainer upgrade --workspace-folder $image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But doesn’t that one also updates the versions in manifests?
Whenever I create a PR with some changes, I prefer to run upgrade command. Also, so that the dev tags which are scheduled on Monday could test with latest Features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants